This project is mirrored from https://github.com/cockroachdb/cockroach. Pull mirroring updated .
  1. 22 Oct, 2020 40 commits
    • craig[bot]'s avatar
      Merge #55876 · 4702643d
      craig[bot] authored
      55876: logictest: fix comparison logic r=yuzefovich a=otan
      
      `9d2c054f` introduced a bug in the
      commit logic where it would only check logic test errors for the first
      line, since it only compares the first column of results. This is now
      fixed to compare every row.
      
      Release note: None
      Co-authored-by: default avatarOliver Tan <[email protected]>
      4702643d
    • craig[bot]'s avatar
      Merge #55838 · e5470a06
      craig[bot] authored
      55838: xform: split custom functions into multiple files r=RaduBerinde a=mgartner
      
      #### xform: move select.opt functions to select_funcs.go
      
      This is part of a refactoring to split up xform custom functions,
      similar to normalization custom functions.
      
      Release note: None
      
      #### xform: move limit.opt functions to limit_funcs.go
      
      Release note: None
      
      #### xform: move groupby.opt functions to groupby_funcs.go
      
      Release note: None
      
      #### xform: move join.opt functions to join_funcs.go
      
      Release note: None
      Co-authored-by: default avatarMarcus Gartner <[email protected]>
      e5470a06
    • craig[bot]'s avatar
      Merge #55783 · 3853555a
      craig[bot] authored
      55783: row: fix crash during tracing given un-decodable datum r=jordanlewis a=jordanlewis
      
      Previously, if tracing was enabled on a query that read bytes that
      weren't decodable into datum, the database would crash.
      
      Release note (bug fix): fix rare crash during tracing when reading
      un-decodable data.
      Co-authored-by: default avatarJordan Lewis <[email protected]>
      3853555a
    • Oliver Tan's avatar
      logictest: fix comparison logic · bc1b3e53
      Oliver Tan authored
      `9d2c054f` introduced a bug in the
      commit logic where it would only check logic test errors for the first
      line, since it only compares the first column of results. This is now
      fixed to compare every row.
      
      Release note: None
      bc1b3e53
    • craig[bot]'s avatar
      Merge #55828 #55853 #55857 #55863 · badbaadc
      craig[bot] authored
      55828: roachtest: disable range merge queue in tpchvec/tpcdsvec r=yuzefovich a=yuzefovich
      
      This commit disables the range merge queue on tpchvec and tpcdsvec
      roachtests in order to - hopefully - reduce some noise about the
      performance slowness. I'm guessing that some of the variation that we've
      been observing with tpchvec/perf tests might come due to range merge
      activity, so let's remove that variable. However, I don't have concrete
      data to back this guess up.
      
      Release note: None
      
      55853: ccl/backupccl: skip TestBackupRestoreAppend under race r=rytaft a=rytaft
      
      Refs: #50984, #54599
      
      Reason: flaky test
      
      Generated by bin/skip-test.
      
      Release justification: non-production code changes
      
      Release note: None
      
      55857: cmd,skip: add flag to skip test under race r=rytaft a=rytaft
      
      This commit updates the `skip-test` command to support a flag `-under_race`,
      which only skips the test under race builds. This commit also adds a new
      function to the skip package, `UnderRaceWithIssue`, which makes it easier to
      skip a test under race and log the associated issue.
      
      Release note: None
      
      55863: util: add skip.UnderMetamorphic; skip a test r=jordanlewis a=jordanlewis
      
      One test cannot be run under the metamorphic build configuration, since
      its output depends on the batch size: the test counts the number of
      spans scanned, which will go up with a small batch size due to the table
      reader resuming the scan until its finished.
      
      Release note: None
      Co-authored-by: default avatarYahor Yuzefovich <[email protected]>
      Co-authored-by: default avatarRebecca Taft <[email protected]>
      Co-authored-by: default avatarJordan Lewis <[email protected]>
      badbaadc
    • Yahor Yuzefovich's avatar
      roachtest: disable range merge queue in tpchvec/tpcdsvec · a78e336f
      Yahor Yuzefovich authored
      This commit disables the range merge queue on tpchvec and tpcdsvec
      roachtests in order to - hopefully - reduce some noise about the
      performance slowness. I'm guessing that some of the variation that we've
      been observing with tpchvec/perf tests might come due to range merge
      activity, so let's remove that variable. However, I don't have concrete
      data to back this guess up.
      
      Release note: None
      a78e336f
    • craig[bot]'s avatar
      Merge #55796 · 3b3d2739
      craig[bot] authored
      55796: colexecagg: move the aggregate functions into a separate package r=yuzefovich a=yuzefovich
      
      This commit does the following:
      - moves all aggregate functions into the newly created `colexecagg`
      package
      - moves previously private struct `colexec.overloadHelper` into
      `execgen` package and exports the struct and all of its fields
      - moves `colexec.Closer` into `colexecbase`
      - moves `colexec.GetDatumToPhysical` to `colconv` package and renames
      the file where that function lives from `utils` to `datum_to_vec`.
      
      This is done as the first step at reducing the size of `colexec`
      package.
      
      Release note: None
      Co-authored-by: default avatarYahor Yuzefovich <[email protected]>
      3b3d2739
    • Yahor Yuzefovich's avatar
      colexecagg: move the aggregate functions into a separate package · d61a4260
      Yahor Yuzefovich authored
      This commit does the following:
      - moves all aggregate functions into the newly created `colexecagg`
      package
      - moves previously private struct `colexec.overloadHelper` into
      `execgen` package and exports the struct and all of its fields
      - moves `colexec.Closer` into `colexecbase`
      - moves `colexec.GetDatumToPhysical` to `colconv` package and renames
      the file where that function lives from `utils` to `datum_to_vec`.
      
      This is done as the first step at reducing the size of `colexec`
      package.
      
      Release note: None
      d61a4260
    • Rebecca Taft's avatar
      cmd,skip: add flag to skip test under race · 1c9d5519
      Rebecca Taft authored
      This commit updates the skip-test command to support a flag -under_race,
      which only skips the test under race builds. This commit also adds a new
      function to the skip package, UnderRaceWithIssue, which makes it easier to
      skip a test under race and log the associated issue.
      
      Release note: None
      1c9d5519
    • Marcus Gartner's avatar
      xform: move join.opt functions to join_funcs.go · 457c9748
      Marcus Gartner authored
      Release note: None
      457c9748
    • Marcus Gartner's avatar
      xform: move groupby.opt functions to groupby_funcs.go · 9649d4bf
      Marcus Gartner authored
      Release note: None
      9649d4bf
    • Marcus Gartner's avatar
      xform: move limit.opt functions to limit_funcs.go · 92573d7c
      Marcus Gartner authored
      Release note: None
      92573d7c
    • Marcus Gartner's avatar
      xform: move select.opt functions to select_funcs.go · b35db686
      Marcus Gartner authored
      This is part of a refactoring to split up xform custom functions,
      similar to normalization custom functions.
      
      Release note: None
      b35db686
    • craig[bot]'s avatar
      Merge #55350 · 4e88183e
      craig[bot] authored
      55350: server: support adding stores to existing nodes r=irfansharif a=TheSamHuang
      
      We need to bootstrap additional stores asynchronously. Consider the range that
      houses the store ID allocator. When restarting the set of nodes that holds a
      quorum of these replicas, when restarting them with additional stores, those
      additional stores will require store IDs to get fully bootstrapped. But if
      we're gating node start (specifically opening up the RPC floodgates) on having
      all stores fully bootstrapped, we'll simply hang when trying to allocate store
      IDs.  See TestAddNewStoresToExistingNodes and #39415 for more details.
      
      Instead we opt to bootstrap additional stores asynchronously, and rely on the
      blocking function to signal to the caller that all stores have been fully
      bootstrapped.
      Co-authored-by: default avatarirfan sharif <[email protected]>
      4e88183e
    • craig[bot]'s avatar
      Merge #55780 · b8249136
      craig[bot] authored
      55780: sql,colexec: fix distinct aggregation r=yuzefovich a=yuzefovich
      
      **colexec: fix tuple index mismatch in ordered distinct aggregation**
      
      We're handling the DISTINCT aggregations by populating new selection
      vector to include only the tuples that are distinct to be aggregated by
      a particular function. Previously, we would convert the arguments to
      default aggregate function in case of ordered aggregation "with
      deselection" step (this is a minor optimization). However, combining
      these two things makes it very hard to know at which position in the
      converted []tree.Datum vectors the arguments of a tuple actually live
      which would result in us using the wrong ones. As a result, when
      actually performing the aggregation we could see that there is
      a selection vector (populated by the distinctness helper), yet there was
      no original selection vector on the batch itself, so we would use
      incorrect indices to look up the arguments in the converted []tree.Datum
      slices.
      
      Now this is fixed by following the pattern of the hash aggregator -
      converting the input argument vectors without the deselection. In order
      for the bug to be triggered we need to have at least two aggregate
      functions with one of them handled by the default aggregate function (i.e.
      it doesn't have an optimized implementation) with DISTINCT clause (if
      the projection contains only that function, then the distinct operation
      is pushed out of the aggregation into a distinct stage).
      
      Fixes: #55776.
      
      Release note (bug fix): CockroachDB could previously incorrectly compute
      some aggregate functions with DISTINCT clauses when the query projects
      other columns/functions and the vectorized engine was used. This bug was
      introduced in 20.2.0.alpha.3 release.
      
      **sql: fix planning of distinct stage with mix of (non-)distinct aggregations**
      
      When performing the physical planning of aggregation we have some
      optimizations:
      - we try to distribute the actual aggregation if all functions support
      it, the previous stage is distributed, and no function has DISTINCT
      clause
      - if we can't do a multi-stage aggregation, then we might plan
      a distributed distinct stage if all functions have a DISTINCT clause.
      
      However, previously, we could incorrectly evaluate whether all functions
      have a DISTINCT clause if the function that doesn't support distributed
      computation is preceding non-distinct function because we broke out of
      the loop. As an example, queries like `SELECT corr(DISTINCT y, x),
      count(y) ...` would incorrectly think that they can do local distinct
      operation, but this would lead to incorrect results.
      
      This is now fixed by separating out the optimization of performing
      a local distinct stage (which is always beneficial to do; when all
      functions have DISTINCT clause) and then deciding whether we can do
      multi-stage aggregation.
      
      Fixes: #55837.
      
      Release note (bug fix): CockroachDB previously could return incorrect
      results in rare circumstances when computing the aggregation functions
      when some of the functions have DISTINCT clause and some don't (the
      latter might not see all the necessary data), and this is now fixed.
      This bug has been present for several years.
      Co-authored-by: default avatarYahor Yuzefovich <[email protected]>
      b8249136
    • Yahor Yuzefovich's avatar
      sql: fix planning of distinct stage with mix of (non-)distinct aggregations · f7c9cb34
      Yahor Yuzefovich authored
      When performing the physical planning of aggregation we have some
      optimizations:
      - we try to distribute the actual aggregation if all functions support
      it, the previous stage is distributed, and no function has DISTINCT
      clause
      - if we can't do a multi-stage aggregation, then we might plan
      a distributed distinct stage if all functions have a DISTINCT clause.
      
      However, previously, we could incorrectly evaluate whether all functions
      have a DISTINCT clause if the function that doesn't support distributed
      computation is preceding non-distinct function because we broke out of
      the loop. As an example, queries like `SELECT corr(DISTINCT y, x),
      count(y) ...` would incorrectly think that they can do local distinct
      operation, but this would lead to incorrect results.
      
      This is now fixed by separating out the optimization of performing
      a local distinct stage (which is always beneficial to do; when all
      functions have DISTINCT clause) and then deciding whether we can do
      multi-stage aggregation.
      
      Release note (bug fix): CockroachDB previously could return incorrect
      results in rare circumstances when computing the aggregation functions
      when some of the functions have DISTINCT clause and some don't (the
      latter might not see all the necessary data), and this is now fixed.
      This bug has been present for several years.
      f7c9cb34
    • Yahor Yuzefovich's avatar
      colexec: fix tuple index mismatch in ordered distinct aggregation · c2b82043
      Yahor Yuzefovich authored
      We're handling the DISTINCT aggregations by populating new selection
      vector to include only the tuples that are distinct to be aggregated by
      a particular function. Previously, we would convert the arguments to
      default aggregate function in case of ordered aggregation "with
      deselection" step (this is a minor optimization). However, combining
      these two things makes it very hard to know at which position in the
      converted []tree.Datum vectors the arguments of a tuple actually live
      which would result in us using the wrong ones. As a result, when
      actually performing the aggregation we could see that there is
      a selection vector (populated by the distinctness helper), yet there was
      no original selection vector on the batch itself, so we would use
      incorrect indices to look up the arguments in the converted []tree.Datum
      slices.
      
      Now this is fixed by following the pattern of the hash aggregator -
      converting the input argument vectors without the deselection. In order
      for the bug to be triggered we need to have at least two aggregate
      functions with one of them handled by the default aggregate function (i.e.
      it doesn't have an optimized implementation) with DISTINCT clause (if
      the projection contains only that function, then the distinct operation
      is pushed out of the aggregation into a distinct stage).
      
      Release note (bug fix): CockroachDB could previously incorrectly compute
      some aggregate functions with DISTINCT clauses when the query projects
      other columns/functions and the vectorized engine was used. This bug was
      introduced in 20.2.0.alpha.3 release.
      c2b82043
    • craig[bot]'s avatar
      Merge #55742 · d82dc5c8
      craig[bot] authored
      55742: opt: change rule for anti joins using inverted index r=sumeerbhola a=sumeerbhola
      
      These are now converted into paired joins consisting of
      a left outer inverted join followed by an left anti
      lookup join. This is more efficient than the previous
      approach that involved two left outer joins and removal
      of the matching rows using a select.
      
      Release note: None
      Co-authored-by: default avatarsumeerbhola <[email protected]>
      d82dc5c8
    • irfan sharif's avatar
      server: support adding stores to existing nodes · 991a01d9
      irfan sharif authored
      We need to bootstrap additional stores asynchronously. Consider the range that
      houses the store ID allocator. When restarting the set of nodes that holds a
      quorum of these replicas, when restarting them with additional stores, those
      additional stores will require store IDs to get fully bootstrapped. But if
      we're gating node start (specifically opening up the RPC floodgates) on having
      all stores fully bootstrapped, we'll simply hang when trying to allocate store
      IDs.  See TestAddNewStoresToExistingNodes and #39415 for more details.
      
      Instead we opt to bootstrap additional stores asynchronously, and rely on the
      blocking function to signal to the caller that all stores have been fully
      bootstrapped.
      
      Release note: None
      Co-authored-by: default avatarSam Huang <[email protected]>
      Co-authored-by: default avatarTobias Grieger <[email protected]>
      991a01d9
    • craig[bot]'s avatar
      Merge #55792 · fa45ab4b
      craig[bot] authored
      55792: opt: rework tests involving scalar expressions r=RaduBerinde a=RaduBerinde
      
      #### opt: simplify execbuilder.BuildScalar
      
      In all uses of BuildScalar, we map variables directly to columns in
      the metadata. This change simplifies the interface and makes an
      indexed var container internally.
      
      Release note: None
      
      #### opt: rework scalar optbuilder tests
      
      This change reworks the infrastructure for tests involving scalars.
      Instead of passing a list of types and using thing like `@1` to refer
      to variables, we define variables with names. This makes the tests a
      lot cleaner and doesn't rely on an obscure syntax. It will also allow
      extending the variable definitions (e.g. computed column expressions).
      
      The new infrastructure will be used for other scalar tests (most
      importantly, index constraints and partial predicate implication).
      
      Release note: None
      
      #### opt: update memo/expr_test to use ScalarVars
      
      Release note: None
      
      #### opt: update composite_sensitive test to use ScalarVars
      
      Release note: None
      
      #### opt: update implicator tests to use ScalarVars
      
      Release note: None
      
      #### opt: update idxconstraint tests to use ScalarVars
      
      Release note: None
      Co-authored-by: default avatarRadu Berinde <[email protected]>
      fa45ab4b
    • craig[bot]'s avatar
      Merge #55637 #55825 · cb31c8cb
      craig[bot] authored
      55637: sql: use new explain format in explain bundles r=RaduBerinde a=RaduBerinde
      
      #### util: treeprinter improvements and new style
      
      This change cleans up the treeprinter implementation and interface and
      adds a "with bullets" style that looks like this:
      ```
        • foo
        │
        ├── • bar1
        │   │ bar2
        │   │
        │   └── • baz
        │
        └── • qux
      ```
      This is a preliminary design from Anne for the new EXPLAIN output.
      
      Release note: None
      
      #### opt: rework explain output test
      
      Changing the explain output test from an Example to a datadriven test
      (which is much easier to update).
      
      Release note: None
      
      #### sql: use new explain format in explain bundles
      
      This change switches the plan string in EXPLAIN ANALYZE (DEBUG)
      bundles to use the new style with bullets. See the updated test for
      some examples.
      
      Release note: None
      
      55825: roachtest: rename AppDev team to SQL Experience r=solongordon a=rafiss
      
      Release note: None
      Co-authored-by: default avatarRadu Berinde <[email protected]>
      Co-authored-by: default avatarRafi Shamim <[email protected]>
      cb31c8cb
    • craig[bot]'s avatar
      Merge #55858 · 840e101d
      craig[bot] authored
      55858: *: Remove cryptopp from c-deps, stop building it r=petermattis a=itsbilal
      
      libcryptopp was only used for RocksDB encryption-at-rest. Now
      that RocksDB is deleted (#55509), we can remove libcryptopp too.
      
      Release note: None.
      Co-authored-by: default avatarBilal Akhtar <[email protected]>
      840e101d
    • Jordan Lewis's avatar
      util: add skip.UnderMetamorphic; skip a test · 7c92a73a
      Jordan Lewis authored
      One test cannot be run under the metamorphic build configuration, since
      its output depends on the batch size: the test counts the number of
      spans scanned, which will go up with a small batch size due to the table
      reader resuming the scan until its finished.
      
      Release note: None
      7c92a73a
    • craig[bot]'s avatar
      Merge #55569 · dd647f5c
      craig[bot] authored
      55569: sessiondata: extract all non-local parameters into a protobuf r=yuzefovich a=yuzefovich
      
      This commit divides up all the session parameters into two categories:
      local only (those that don't influence the execution if not propagated
      to the remote nodes) and non-local (those that must be propagated). The
      former are extracted into a separate struct, and the latter are now
      mostly stored directly in a protobuf with a few exceptions having custom
      serialization/deserialization logic. This allows us to clean up the eval
      context proto and centralize the custom logic and the definition.
      
      This commit also fixed an issue of not propagating the default int size
      which - in theory - could influence the execution on the remote nodes
      (e.g. when performing a cast by an internal executor).
      
      Fixes: #51075.
      
      Release note: None
      Co-authored-by: default avatarYahor Yuzefovich <[email protected]>
      dd647f5c
    • Yahor Yuzefovich's avatar
      sessiondata: extract all non-local parameters into a protobuf · ab19e5c4
      Yahor Yuzefovich authored
      This commit divides up all the session parameters into two categories:
      local only (those that don't influence the execution if not propagated
      to the remote nodes) and non-local (those that must be propagated). The
      former are extracted into a separate struct, and the latter are now
      mostly stored directly in a protobuf with a few exceptions having custom
      serialization/deserialization logic. This allows us to clean up the eval
      context proto and centralize the custom logic and the definition.
      
      This commit also fixed an issue of not propagating the default int size
      which - in theory - could influence the execution on the remote nodes
      (e.g. when performing a cast by an internal executor).
      
      Release note: None
      ab19e5c4
    • sumeerbhola's avatar
      opt: change rule for anti joins using inverted index · 6a93b592
      sumeerbhola authored
      These are now converted into paired joins consisting of
      a left outer inverted join followed by an left anti
      lookup join. This is more efficient than the previous
      approach that involved two left outer joins and removal
      of the matching rows using a select.
      
      Release note: None
      6a93b592
    • Rebecca Taft's avatar
      ccl/backupccl: skip TestBackupRestoreAppend under race · aa486a66
      Rebecca Taft authored
      Refs: #50984, #54599
      
      Reason: flaky test
      
      Generated by bin/skip-test.
      
      Release justification: non-production code changes
      
      Release note: None
      aa486a66
    • Bilal Akhtar's avatar
      *: Remove cryptopp from c-deps, stop building it · ccd4d312
      Bilal Akhtar authored
      libcryptopp was only used for RocksDB encryption-at-rest. Now
      that RocksDB is deleted (#55509), we can remove libcryptopp too.
      
      Release note: None.
      ccd4d312
    • craig[bot]'s avatar
      Merge #55785 · 8d5790f9
      craig[bot] authored
      55785: sql: create event log entry for schema events r=jordanlewis,arulajmani a=neeral
      
      Previously, events were not created when schema objects were
      created, dropped or modified.
      
      Fixes #55744 
      
      Release note (admin ui change): changing schema object
      now causes an event to be logged and displayed in the admin ui
      Co-authored-by: default avatarneeral <[email protected]>
      8d5790f9
    • Radu Berinde's avatar
      sql: use new explain format in explain bundles · 09a01236
      Radu Berinde authored
      This change switches the plan string in EXPLAIN ANALYZE (DEBUG)
      bundles to use the new style with bullets. See the updated test for
      some examples.
      
      Release note: None
      09a01236
    • Radu Berinde's avatar
      opt: rework explain output test · 55f96a6e
      Radu Berinde authored
      Changing the explain output test from an Example to a datadriven test
      (which is much easier to update).
      
      Release note: None
      55f96a6e
    • Radu Berinde's avatar
      util: treeprinter improvements and new style · 732253fc
      Radu Berinde authored
      This change cleans up the treeprinter implementation and interface and
      adds a "with bullets" style that looks like this:
      ```
        • foo
        │
        ├── • bar1
        │   │ bar2
        │   │
        │   └── • baz
        │
        └── • qux
      ```
      This is a preliminary design from Anne for the new EXPLAIN output.
      
      Release note: None
      732253fc
    • neeral's avatar
      sql: create event log entry for schema events · 4641c2c8
      neeral authored
      Previously, events were not created when schema objects were
      created, dropped or modified.
      
      Fixes #55744
      
      Release note (admin ui change): changing schema object
      now causes an event to be logged and displayed in the admin ui
      4641c2c8
    • craig[bot]'s avatar
      Merge #55855 · 2385a186
      craig[bot] authored
      55855: build: remove unused ROCKSDB variables r=jordanlewis a=jordanlewis
      
      Release note: None
      Co-authored-by: default avatarJordan Lewis <[email protected]>
      2385a186
    • Jordan Lewis's avatar
      build: remove unused ROCKSDB variables · 2701d100
      Jordan Lewis authored
      Release note: None
      2701d100
    • craig[bot]'s avatar
      Merge #55499 · ee2e28df
      craig[bot] authored
      55499: ui: update styles for session details page r=koorosh a=koorosh
      
      resolves #54513 
      depends on https://github.com/cockroachdb/admin-ui-components/pull/31
      depends on https://github.com/cockroachdb/admin-ui-components/pull/34
      depends on https://github.com/cockroachdb/admin-ui-components/pull/35
      
      Current fix is quite complex and touches a lot of places because most of the issues with styles were common for all pages (Statements, Jobs, Node Overview).
      Also many style duplicates required to get rid of duplicates and unify single version of proper components to use across entire app.
      
      It's easier to review this PR per commit. Each commit describes in details what changes were made and their purpose.
       
      ![Screen Shot 2020-10-13 at 3 18 18 PM](https://user-images.githubusercontent.com/3106437/95859522-690a3000-0d67-11eb-94bb-1cccaac1d816.png)
      
      ![Screen Shot 2020-10-13 at 1 43 23 PM](https://user-images.githubusercontent.com/3106437/95856423-a9b37a80-0d62-11eb-8ade-54e8ed5b895c.png)
      Co-authored-by: default avatarAndrii Vorobiov <[email protected]>
      ee2e28df
    • craig[bot]'s avatar
      Merge #55509 · fdeb78ba
      craig[bot] authored
      55509: *: Remove RocksDB r=itsbilal a=itsbilal
      
      As in title. Removes RocksDB and snappy, from the `c-deps` directory,
      and updates tests and roachtests to reflect a Pebble-only world. Libroach
      is slimmed to just the one method (`DumpThreadStacks`) that is still necessary.
      
      As this is a massive change, I've tried to make it as easy to review as possible by
      splitting changes in different commits. The first commit just updates temp file locking,
      the second commit deletes RocksDB-specific code paths and updates the few remaining
      RocksDB-only tests to use equivalent Pebble code paths, the fourth commit has
      Makefile changes, and the last commit is a plain file deletion in `c-deps`. 
      
      This is ready for review, though the following relatively-minor tasks are still TODO:
      
      - [x] Resolve merge conflicts
      - [x] Pass lint
      - [x] Bring back thread stack dumps as they may be necessary for inspecting other CGo code
      Co-authored-by: default avatarBilal Akhtar <[email protected]>
      fdeb78ba
    • craig[bot]'s avatar
      Merge #55843 #55844 · 40199771
      craig[bot] authored
      55843: roachpb: track a few auto-generated files as binary files r=irfansharif a=irfansharif
      
      Makes the `git` invocations a bit more useful.
      
      Release note: None
      
      55844: keys: update doc.go to include node tombstone key r=irfansharif a=irfansharif
      
      Release note: None
      Co-authored-by: default avatarirfan sharif <[email protected]>
      40199771
    • Radu Berinde's avatar
      opt: update idxconstraint tests to use ScalarVars · 5faff5d5
      Radu Berinde authored
      Release note: None
      5faff5d5
    • Radu Berinde's avatar
      opt: update implicator tests to use ScalarVars · d31f394f
      Radu Berinde authored
      Release note: None
      d31f394f