Commit e9937573 authored by Rafi Shamim's avatar Rafi Shamim

errorutil/unimplemented: use redirect server for Github links

This will allow us to capture telemetry such as click counts for each
unimplemented error that is returned.

Release note (general change): Links that are returned in error messages
to point to unimplemented issues now use the CockroachLabs
redirect/short-link server.
parent 69bc0192
......@@ -316,7 +316,7 @@ ALTER TABLE t10 ALTER COLUMN y TYPE STRING
statement ok
CREATE TABLE t11 (x INT)
statement error pq: unimplemented: ALTER COLUMN TYPE USING EXPRESSION is not supported\nHINT: You have attempted to use a feature that is not yet implemented.\nSee: https://github.com/cockroachdb/cockroach/issues/47706
statement error pq: unimplemented: ALTER COLUMN TYPE USING EXPRESSION is not supported\nHINT: You have attempted to use a feature that is not yet implemented.\nSee: https://go.crdb.dev/issue/47706
ALTER TABLE t11 ALTER COLUMN x TYPE STRING USING CAST(x AS STRING)
# Ensure ALTER COLUMN TYPE is disallowed if the column has a constraint.
......
......@@ -3416,7 +3416,7 @@ func TestUnimplementedSyntax(t *testing.T) {
t.Errorf("%s: expected %q in telemetry keys, got %+v", d.sql, exp, tkeys)
}
exp2 := fmt.Sprintf("issues/%d", d.issue)
exp2 := fmt.Sprintf("issue/%d", d.issue)
found = false
hints := errors.GetAllHints(err)
for _, h := range hints {
......
......@@ -100,5 +100,5 @@ func unimplementedInternal(
// MakeURL produces a URL to a CockroachDB issue.
func MakeURL(issue int) string {
return fmt.Sprintf("https://github.com/cockroachdb/cockroach/issues/%d", issue)
return fmt.Sprintf("https://go.crdb.dev/issue/%d", issue)
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment