Commit 7f0232ff authored by Nathan VanBenschoten's avatar Nathan VanBenschoten

kv: drop default for kv.bulk_sst.sync_size and kv.snapshot_sst.sync_size

These were both defaulting to 2MB per fsync. In Peter's testing, 512 MB
per sync is a better value.
parent 0b65365f
......@@ -858,7 +858,7 @@ var recoverySnapshotRate = settings.RegisterPublicValidatedByteSizeSetting(
var snapshotSSTWriteSyncRate = settings.RegisterByteSizeSetting(
"kv.snapshot_sst.sync_size",
"threshold after which snapshot SST writes must fsync",
2<<20, /* 2 MiB */
bulkIOWriteBurst,
)
func snapshotRateLimit(
......
......@@ -25,8 +25,10 @@ import (
"golang.org/x/time/rate"
)
// bulkIOWriteBurst is the burst for the BulkIOWriteLimiter.
const bulkIOWriteBurst = 2 * 1024 * 1024 // 2MB
// bulkIOWriteBurst is the burst for the BulkIOWriteLimiter. It is also used as
// the default value for the kv.bulk_sst.sync_size and kv.snapshot_sst.sync_size
// cluster settings.
const bulkIOWriteBurst = 512 << 10 // 512 KB
const bulkIOWriteLimiterLongWait = 500 * time.Millisecond
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment